Re: Packaging tomcat shell scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/23/2013 01:09 PM, Dridi Boukelmoune wrote:
On Wed, Oct 23, 2013 at 1:57 PM, Robert Rati <rrati@xxxxxxxxxx> wrote:
Here's a listing of the directory structure hadoop and similar bits produce
in their builds:

http://paste.fedoraproject.org/48849/13825327

Looks like tomcat is bundled, which itself is an issue.

I've got a patch that pulls out the d/ling and bundling of tomcat. That's not a problem.

There's a some stuff in there that's can obviously be paired down. Here's
the script used to start/stop the service:

http://paste.fedoraproject.org/48852/38253290

This whole script could be replaced by a in-house script just like
/usr/sbin/tomcat, and it should be fairly easy.

A few things I've spotted:
- PRG=$(readlink -f $0) could replace the whole while loop line 19
   It's not portable, but we don't care since it'd work on Fedora
- The so-called bug mentioned line 51 is actually documented [1] in catalina.sh
   It works like this by design, I'll notify upstream

I'd prefer to avoid fedora specific changes. We'd like to push as much as possible upstream and that's difficult enough. Upstream moves fast and the recent rebase to 2.2.0 was quite a bit of work. If what upstream provides will work then I'd like to avoid adding more work for future rebases.

It should be noted that upstream hadoop, and its ecosystem, use tomcat 6.x
and as part of packaging it we've moved forward to tomcat 7.x.

Unless hadoop's code uses tomcat internals (a valve for instance) this
should not be a problem. I don't have time right now do check that.


Hadoop uses jasper and jspc and we've ported all that stuff forward to the latest in fedora. There's no need to dive into this mess unless you're curious or like pain. :)

Rob
--
java-devel mailing list
java-devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/java-devel





[Index of Archives]     [Red Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux