On 1/13/20 9:12 AM, Stefan Wahren wrote:
On 13.01.20 07:19, Peter Robinson wrote:
Hello guys,
just to let you know, Eric Dumazet from netdev mailing list found 2 bugs
one related to a memory leak (just been added to mainstream)
one related to gso max size (from yesterday night)
with both patches I am not able to reproduce the issue !!
Do you have a link to the upstream patches on the list by chance?
The following two patches made it into 5.4.11:
- net: usb: lan78xx: fix possible skb leak
Yes
- net: usb: lan78xx: Fix error message format specifier
AFAIK there is no proper patch for the GSO issue yet.
Was it them or something else?
here is the comment from Eric for the last patch
lan78xx_tx_bh() makes sure to not exceed MAX_SINGLE_PACKET_SIZE
bytes in the aggregated packets it builds, but does
nothing to prevent large GSO packets being submitted.
Pierre-Francois reported various hangs when/if TSO is enabled.
For localy generated packets, we can use netif_set_gso_max_size()
to limit the size of TSO packets.
Note that forwarded packets could still hit the issue,
so a complete fix might require implementing .ndo_features_check
for this driver, forcing a software segmentation if the size
of the TSO packet exceeds MAX_SINGLE_PACKET_SIZE.
Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
Fox
_______________________________________________
arm mailing list -- arm@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to arm-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/arm@xxxxxxxxxxxxxxxxxxxxxxx
