Re: [PATCH] Possible fix for u-boot on wandboard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I can see how you zero in on that area of code as that is where is has
"Wrong Image Format".
(final words when the kernel does not boot with wandboard  quad)

Looking at the 2013.10-rc3 source from the current SRPM, I'm not sure
this patch would apply, probably not.

The cmdtp is the so-called "bootm command table" as noted in the
comments of cmd_bootm.c
So I would imagine cmdtp->cmd would be the string 'bootm' , but could be wrong.
Maybe the "cmdtp" is getting trashed somewhere along the line, and
poking the variable reveals problem.

My only problem with the patch is the area of code might be helpful on
other (working) boards.
Then again, I'm inclined to just hardcode the string 'bootm' right
there and be done.

It would be interesting to turn on/off CONFIG_FIT or whatever, the
ifdef's all around there seems to matter.


-Jon Disnard

On Sat, Sep 21, 2013 at 8:18 PM, Steven Falco <stevenfalco@xxxxxxxxx> wrote:
> I've been looking into the reason why my wandboard would
> not boot Fedora reliably.  I would typically get one
> good boot every 3 or 4 tries.
>
> It is late, and I need to stop now, but the following
> proposed patch to uboot allows my board to boot without
> errors, at least a dozen times in a row, which it has
> never done before.
>
> Basically, cmdtp->name is not valid for some reason,
> so uboot goes off into the weeds.  I have not tracked
> down the explanation, but if anyone else would like to
> give this a try, I'd very much appreciate the feedback.
>
> Signed-off-by: Steven A. Falco <stevenfalco@xxxxxxxxx>
>
> --
>
> diff -ur BUILD.original/u-boot-2013.07/common/cmd_bootm.c
> BUILD/u-boot-2013.07/common/cmd_bootm.c
> --- BUILD.original/u-boot-2013.07/common/cmd_bootm.c    2013-07-23
> 07:58:13.000000000 -0400
> +++ BUILD/u-boot-2013.07/common/cmd_bootm.c     2013-09-21
> 21:08:10.623374338 -0400
> @@ -997,7 +998,7 @@
>                 break;
>  #endif
>         default:
> -               printf("Wrong Image Format for %s command\n", cmdtp->name);
> +               printf("Wrong Image Format for command\n");
>                 bootstage_error(BOOTSTAGE_ID_FIT_KERNEL_INFO);
>                 return NULL;
>         }
>
>
> _______________________________________________
> arm mailing list
> arm@xxxxxxxxxxxxxxxxxxxxxxx
> https://admin.fedoraproject.org/mailman/listinfo/arm



-- 

-Jon
_______________________________________________
arm mailing list
arm@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/arm





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM (Vger)]     [Linux ARM]     [ARM Kernel]     [Fedora User Discussion]     [Older Fedora Users Discussion]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Maintainers]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [Linux Apps]     [KDE Users]     [Fedora Tools]     [Fedora Art]     [Fedora Docs]     [Asterisk PBX]

Powered by Linux