On Mon, Jul 20, 2009 at 01:11:29PM -0400, Cole Robinson wrote: > Hi all, > > The attached patch adds a small wizard for cloning a VM. A screenshot of > the overview: > > http://fedorapeople.org/~crobinso/virt-manager/clone-post/vmm-clone-overview.png > > The wizard will generate a new VM name (usually <orig-name>-clone), new > storage paths as required, and MAC addresses. Storage is marked as > one of: > > - Shared: Original and clone VM point to the same disk image > - Clone : Actually copy the original storage for use by the clone > > Storage like removable media (cdrom, floppy), readonly or shareable > disks will be 'Shared' by default. > > The storage drop down has a 'Details' choice: > > http://fedorapeople.org/~crobinso/virt-manager/clone-post/vmm-clone-dropdown.png > > This brings up a small dialog which allows changing the new disk path: > > http://fedorapeople.org/~crobinso/virt-manager/clone-post/vmm-clone-storage-details.png > > There is also a similar dialog for changing MAC addresses. > > If we can't clone storage (maybe lack of permissions, or remote > unmanaged storage, older libvirt), we still allow cloning the VM, but > force the offending disks into 'Shared' mode. In the case of sharing a > read/write disk, we give a clear warning that this may result in > overwriting the original image. IMHO, we should simply disallow that. Users would expect that cloning a guest is guarneteed to not impact the original. If we can't guarentee that, we should refuse to clone it. Swiching a private disk to shared mode is giving a user a loaded gun with no safety catch & a touch sensitive trigger. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
