On Mon, May 11, 2009 at 02:12:15PM -0400, Cole Robinson wrote: > Guido Günther wrote: > > Hi, > > the attached patch is a first attempt to make virt-manager better usable > > under tiling window managers like awesome[1]. The problem is that > > virt-manager opens dialogs without a parent set (like passing NULL as > > the first argument of gtk_message_dialog_new). This patch is a first > > attempt on fixing that for some of them. This way dialogs like the about > > dialog get displayed in the middle of the main window instead of > > floating. Does this look like the right thing to do? > > Cheers, > > -- Guido > > > > I can't claim to know the ins and outs of gtk, but this seems like the > correct thing to do, and if it solves actual problems then I'm all for it. This seems to pass in the main manager window to each of virt-manager's other windows, and uses that as the parent of the about dialog. I don't see how this will work in scenarios where the main manager window is not visible. If using gnome-terminal, for example with many terminals open, the window simply gets shown above the window I select Help->About from, and if you select 'Help -> About' from many windows, it just opens one new instance each time. I think this is simpler than trying to keep a singleton about window and making it track the manager window. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
