On Tue, Dec 16, 2008 at 01:50:22PM -0700, Pat Campbell wrote: > > Attached patch modifies virt-viewer so that it acquires the "Send key" > menu contents from an xml file and allows user to load a browsed for > keymap def file while running. I like the idea of making it configurable, but not the idea of having the user create & load XML files for this. If a user wants a custom send-key set, they'll likely want it preserved and used across all instances of virt-viewer automatically every time it is started rather than having to load the file. I think we should store the custom send-key sets in GConf, rather than XML files, and at the bottom of the 'send key' menu have an final entry 'Edit keys...' which pops up a dialog allowing the user to add or remove keys from the menu. Just letting them enter the key name (which we can validate by just doing a lookup on the string they enter). GConf would ensure changes in one instance are instant applied to all other running instances. If we want to get adventurous later on we could add 'profiles' to define a set of keys, allowing switching between profiles, and remember which profile is associated with each VM UUID. This would allow user to have one set of keys for Windows VMs, with anothe for Linux, and another for BSD or whatever. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
