Re: [patch] virt-image verify disk checksum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



updated to use corrected method




Cole Robinson wrote:
Joey Boggs wrote:
This patch will make use of the recent disk checksum function for virt-image and verifies prior to importing


diff -r 9f45a36d8242 virt-image
--- a/virt-image	Thu Oct 16 11:18:49 2008 -0400
+++ b/virt-image	Fri Oct 17 16:12:16 2008 -0400
@@ -145,6 +145,8 @@
     parser.add_option("", "--replace",action="store_true", dest="replace",
                       help=_("Overwrite, or destroy, an existing image with the same name"),
default=False) + parser.add_option("","--skip-checksum", action="store_true", dest="skipchecksum",
+                      help=_("Skip disk checksum verification process"))
(options,args) = parser.parse_args()
     if len(args) < 1:
@@ -204,6 +206,10 @@
         if options.noapic:
             guest.features["apic"] = False
+ if not options.skipchecksum:
+        for d in image.storage.values():
+            virtinst.ImageParser.Disk.check_disk_signature(d)
+

This line just abuses the way python does object orientation. You
want to do:

    if not options.skipchecksum:
        for disk in image.storage.values():
            disk.check_disk_signature()

Thanks,
Cole



diff -r 9f45a36d8242 virt-image
--- a/virt-image	Thu Oct 16 11:18:49 2008 -0400
+++ b/virt-image	Mon Oct 20 11:00:23 2008 -0400
@@ -145,6 +145,8 @@
     parser.add_option("", "--replace",action="store_true", dest="replace",
                       help=_("Overwrite, or destroy, an existing image with the same name"),
                       default=False)                      
+    parser.add_option("","--skip-checksum", action="store_true", dest="skipchecksum",
+                      help=_("Skip disk checksum verification process"))
 
     (options,args) = parser.parse_args()
     if len(args) < 1:
@@ -204,6 +206,10 @@
         if options.noapic:
             guest.features["apic"] = False
 
+    if not options.skipchecksum:
+        for disk in image.storage.values():
+            disk.check_disk_signature()
+    
     progresscb = progress.TextMeter()
 
     # we've got everything -- try to start the install
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Index of Archives]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux