On Wed, Oct 08, 2008 at 12:22:05PM -0400, Joey Boggs wrote:
> This adds the underlying support for disk signatures into virt-convert
> disk class for each disk. Additional changes to follow in completing
> implementation
There's not much point in doing md5 and sha1, both are more or
less equivalent strength and compromised algorithms. Doing both
is just wasting CPU resources. Pick either md5 or sha1 for sake
of compatability with old python, and then sha256 for strength.
> diff -r 2aba69a1a16c virtconv/diskcfg.py
> --- a/virtconv/diskcfg.py Mon Oct 06 12:21:17 2008 -0400
> +++ b/virtconv/diskcfg.py Wed Oct 08 12:19:19 2008 -0400
> @@ -53,6 +53,11 @@
> "vdisk": DISK_FORMAT_VDISK,
> }
>
> +checksum_types = {
> + CSUM_MD5 = 'md5'
> + CSUM_SHA1 = 'sha1'
> + CSUM_SHA256 = 'sha256'
> +}
> def ensuredirs(path):
> """
> Make sure that all the containing directories of the given file
> @@ -83,6 +88,7 @@
> self.bus = bus
> self.type = type
> self.clean = []
> + self.csum_dict = {}
>
> def cleanup(self):
> """
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
