On Tue, Sep 23, 2008 at 09:53:33AM +0100, Daniel P. Berrange wrote:
> > > diff -r f87154697807 virt-convert
> > > --- a/virt-convert Thu Sep 18 16:44:30 2008 -0400
> > > +++ b/virt-convert Mon Sep 22 12:17:55 2008 -0400
> > > @@ -49,8 +49,7 @@
> > > opts.add_option("-i", "--input-format", action="store",
> > > dest="input_format", help=("Input format, e.g. 'vmx'"))
> > > opts.add_option("-o", "--output-format", action="store",
> > > - dest="output_format", default="virt-image",
> > > - help=("Output format, e.g. 'virt-image'"))
> > > + dest="output_format", help=("Output format, e.g. 'virt-image / vmware'"))
> >
> > Since we are using 'vmx' as an input format type, we
> > should probably also use it as the name of the output
> > format (not 'vmware').
>
> Yes that's a good idea - you never know if vmware will introduce a new
> non-vmx format, so using 'vmx' makes it clearer which we're talking about.
They already have - OVF :)
regards
john
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
