Re: [PATCH] report block size in add hardware summary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Adam Stokes wrote:
>> First this will need to be duplicated in create.py for the 
>> guest creation wizard. I'd recommend breaking it out into
>> it's own function as well so we don't start adding a lot
>> of logic to the relatively simple get_config_* functions.
> This is complete, though for the logic part im not really sure the best
> way to handle the different varieties that can be seen here
>> Also, could you wrap this code in a try...except block, just
>> log an error if we can't detect the size, and return None.
> Complete as well 
> 
>> Actually could you just bring this up in bz 453061? It's basically
>> covering the same issue.
> 
> Sure thing I've appended this issue to the above BZ.
> 
> Please let me know your thoughts on the latest patch
> 
> Thanks
> 

Thanks! I've committed this:

http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=7a0eb7f2ab10

- Cole

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Index of Archives]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux