Daniel P. Berrange wrote: > On Wed, Jul 23, 2008 at 11:50:51AM -0400, Cole Robinson wrote: >> The attached patch adds a --wait option to virt-install, which >> forces the app to watch the install for a specified number >> of minutes. If the time limit is exceeded, we simply exit >> the app, leaving the domain in whatever state it is in. If >> the vm shuts down as expected, the app continues as usual. >> >> The time limit is regardless of whether a console has been >> specified or if one has already closed. A negative value >> implies waiting indefinitely, and a value of 0 is the same >> as not specifying --wait at all. > > This looks reasonable to me. The only comment I'd have is wrt > to its interaction with --noautoconsole. Perhaps '--wait=0' > should imply --noautoconsole, because otherwise it'd still > actually wait. > > > Daniel That seems reasonable. I'll make that adjustment and commit. Thanks, Cole _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
