john.levon@xxxxxxx wrote: > # HG changeset patch > # User john.levon@xxxxxxx > # Date 1215697572 25200 > # Node ID 112cd8c4aa97e9da9d7532fee7d826d35e1003e8 > # Parent 92de696f634f80d47b9413b9db5101de0edf9b7f > virt-convert: Add "virt-instance" formatter. > > Allow output in libvirt.rng format > So I'm not generally opposed to this idea, however the way this patch implements it is a massive duplication of the virtinst apis, so NACK in this current form. Like Dan mentioned before, if we allow converting to libvirt xml, we need to make it clear that the generated config is really only applicable on the machine it is generated. A connection must be required in order to do the conversion so we can use the virtinst apis and check capabilities xml. This makes it kind of messy since we will have cli options that are relevant for some formats and not for others, but it's unavoidable, and as long as the documentation is clear, it shouldn't be confusing. Thanks, Cole _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
