john.levon@xxxxxxx wrote: > # HG changeset patch > # User john.levon@xxxxxxx > # Date 1215697571 25200 > # Node ID 443b42b45ee6f799020a9418388440b93d9ab78c > # Parent 72eec78868efe7a872eab6c08502b3b84bf00a46 > virt-convert: Add OS variant options > > And use them to set ACPI, APIC, clock, and USB tablet. > I've committed this, though this brings to mind a few things we should change before a next release. Just some thoughts: Duplicating the internal OS dictionary in man pages isn't helpful: we should just add a cli option to virt-install (maybe all the tools that use the dict?) to dump the dictionary in a readable manner and exit. That way the man pages can just say 'see "virt-install --show-me-the-money" for a complete list.' VMX files have a field which specifies the guest os: we should probably try to translate that into an entry in the virtinst OS dict if the user doesn't supply one. Also I think the virt-image format should have an entry for the OS type of the guest, so we should probably add this option to virt-image as well. Thanks, Cole _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
