On Mon, Jul 07, 2008 at 03:51:31PM -0700, john.levon@xxxxxxx wrote: > # HG changeset patch > # User john.levon@xxxxxxx > # Date 1215470367 25200 > # Node ID c75d57437b7b219443580f6e9d6736d27d76ebcf > # Parent a2be1263c2f5d3f346cfc3501682073fce2e8966 > Fix multiple disks > > Fix handling of multiple disks. > > Signed-off-by: John Levon <john.levon@xxxxxxx> > > diff --git a/virtconv/parsers/virtimage.py b/virtconv/parsers/virtimage.py > --- a/virtconv/parsers/virtimage.py > +++ b/virtconv/parsers/virtimage.py > @@ -117,12 +117,12 @@ class virtimage_parser(vmconfig.parser): > > # FIXME: needs updating for later Xen enhancements; need to > # implement capabilities checking for max disks etc. > - pv_disks.append("""<drive disk="%s" target="xvd%s" />""" % > + pv_disks.append("""<drive disk="%s" target="xvd%s" />\n""" % > (path, ascii_letters[number % 26])) > - hvm_disks.append("""<drive disk="%s" target="hd%s" />""" % > + hvm_disks.append("""<drive disk="%s" target="hd%s" />\n""" % > (path, ascii_letters[number % 26])) IDE only allows upto 4 disks. To allow more than this requires use of SCSI or VirtIO/Xen paravirt drivers. I'd probably say default to IDE for first 4, and then switch to sdNNN for any subsequent disks. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools