John Levon wrote:
> On Tue, Jul 01, 2008 at 08:28:01PM +0100, Daniel P. Berrange wrote:
>
>>> diff --git a/virt-unpack b/virt-unpack
>>> --- a/virt-unpack
>>> +++ b/virt-unpack
>>> @@ -119,7 +119,7 @@ def vmx_to_image_xml(disks_list,record,o
>>> if record.has_key("numvcpus"):
>>> vcpus = record["numvcpus"]
>>> else:
>>> - logging.error("numvcpus key not parsed from %s, defaulting to 1 virtual cpu" % file)
>>> + logging.warning("numvcpus key not parsed from %s, defaulting to 1 virtual cpu" % file)
>>> vcpus = "1"
>> IMHO, we shoudn't bother logging anything just silently default
>> it to 1.
>
> Fine by me. What about 'annotation'? I couldn't find this documented on
> sanbarrow.com
>
> regards
> john
>
Since annotation seems to just represent a machine description which can't
be an essential piece, I just removed the logging for it, as well as for
the vcpu default:
http://hg.et.redhat.com/virt/applications/virtinst--devel?cs=ed588cd21acb
Thanks,
Cole
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
