Patch for serial console of virt-manager 0.4 for Solaris

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi there,

I am not sure if I have provided this patch of virt-manager 0.4 for Solaris before, anyway let's list the patch here, and hope you all help to review.


When I tried to run virt-manager 0.4 at Solaris, (we have not port 0.5.* to Solaris since there is some dependencies not ready.) we find the serial console can't run, so added the below patch, after that the serial console can run at Solaris, I took a quick test in Fedora, seems it also can run.

If there is any problem, please let me know..

Thanks,
Henry
diff -Nrup virt-manager-0.4.0/src/virtManager/serialcon.py virt-manager-0.4.0.mod.new/src/virtManager/serialcon.py
--- virt-manager-0.4.0/src/virtManager/serialcon.py     2008-01-21 22:27:00.964332000 +0800
+++ virt-manager-0.4.0.mod.new/src/virtManager/serialcon.py     2008-02-03 23:56:21.913679000 +0800
@@ -23,6 +23,7 @@ import os
 import gobject
 import termios
 import tty
+import pty

 class vmmSerialConsole:
     def __init__(self, config, vm):
@@ -82,11 +83,13 @@ class vmmSerialConsole:
     def opentty(self):
         if self.ptyio != None:
             self.closetty()
-        pty = self.vm.get_serial_console_tty()
+        ipty = self.vm.get_serial_console_tty()

-        if pty == None:
+        if ipty == None:
             return
-        self.ptyio = os.open(pty, os.O_RDWR | os.O_NONBLOCK | os.O_NOCTTY)
+       # delete, because it can't run at Solaris correctly.
+        #self.ptyio = os.open(pty, os.O_RDWR | os.O_NONBLOCK | os.O_NOCTTY)
+       self.ptyio = pty.slave_open(ipty)
         self.ptysrc = gobject.io_add_watch(self.ptyio, gobject.IO_IN | gobject.IO_ERR | gobject.IO_HUP, self.display_data)

         # Save term settings & set to raw mode

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Index of Archives]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux