Re: ANNOUNCE: virt-top 0.3.2.7 released

["Richard W.M. Jones" <rjones@xxxxxxxxxx>]

Richard W.M. Jones wrote:
> Farkas Levente wrote:
> > [root@kvm ~]# /usr/bin/virt-top --connect qemu:///system
> > libvir: error : this function is not supported by the hypervisor:
> > virConnectGetHostname
> > Fatal error: exception Libvirt.Virterror(3, 0, _, 2, _, 0, _, _, 0, _, 
> > _, 0)
> > [root@kvm ~]# rpm -q libvirt
> > libvirt-0.3.2-2
>
> You've found a real bug.  Virt-top is not very well tested against qemu, 
> or rather that should be not tested at all.  But I'll go and try to make 
> it work with qemu now.  Probably take a few hours though ...

The patch to fix that particular bug is attached.  There may be other 
though, still testing ...

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

diff -r 723daeca7dda virt-top/virt_top.ml
--- a/virt-top/virt_top.ml	Thu Sep 20 11:09:32 2007 +0100
+++ b/virt-top/virt_top.ml	Thu Sep 20 15:09:13 2007 +0100
@@ -137,6 +137,9 @@ OPTIONS" in
   let hostname =
     try C.get_hostname conn
     with
+    (* qemu:/// and other URIs didn't support virConnectGetHostname until
+     * libvirt 0.3.3.  Before that they'd throw a virterror. *)
+    | Libvirt.Virterror _
     | Invalid_argument "virConnectGetHostname not supported" -> "unknown" in
 
   let libvirt_version =

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools