Hugh Brock wrote: > Cole Robinson wrote: >> Hugh Brock wrote: >>> Cole Robinson wrote: >>>> Hello all, >>>> >>>> Attached is a patch that adds some simple accessibility names for input >>>> components of virt-manager. This is to facilitate future gui testing. >>>> >>>> Thanks, >>>> Cole >>>> >>> The patch doesn't seem to break anything, but I am getting a warning: >>> libglade-WARNING **: Unexpected element <accessibility> inside <widget>. >>> You know anything about this? >>> >>> Thanks, >>> --Hugh >>> >> Hmm, I tried to reproduce it but I'm not seeing it on fully updated F7 >> at least. I'm guessing this happens when you start up the patched >> virt-manager? >> > > Yeah, I get it when I open the create wizard actually. I was testing on, > umm, latest F7 I think. Could be a bad merge since your patch to > vmm-create.glade merged with offsets. However the message itself is odd; > <accessibility> should be legal inside <widget>. > > Note I see the warning when I run virt-manager from the command line a > la "python virt-manager.py" -- so I am getting all the gtk spew as well. > > I'm inclined to ignore the message unless we think it indicates > something more serious... > > --H > Well it seems there was something funky with the patch. I reworked it and I'm not seeing the error this time (though it may have slipped by since I missed it on the first try!) - Cole -- Cole Robinson crobinso@xxxxxxxxxx
diff -r a52478052b5c src/vmm-add-hardware.glade --- a/src/vmm-add-hardware.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-add-hardware.glade Mon Jul 30 11:31:22 2007 -0400 @@ -177,6 +177,9 @@ <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Hardware Type Select</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -604,6 +607,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Partition Location Field</atkproperty> + </accessibility> </widget> <packing> <property name="padding">0</property> @@ -656,6 +662,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">File Location Field</atkproperty> + </accessibility> <signal name="changed" handler="on_storage_file_address_changed" last_modification_time="Tue, 12 Sep 2006 21:28:45 GMT"/> </widget> <packing> @@ -751,6 +760,9 @@ <property name="snap_to_ticks">True</property> <property name="wrap">False</property> <property name="adjustment">500 0 4000000 100 500 500</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">File Size Field</atkproperty> + </accessibility> <signal name="changed" handler="on_storage_file_size_changed" last_modification_time="Thu, 10 Aug 2006 19:19:04 GMT"/> </widget> </child> @@ -983,6 +995,9 @@ <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Device Type Field</atkproperty> + </accessibility> <signal name="changed" handler="on_target_device_changed" last_modification_time="Sat, 14 Jul 2007 17:06:51 GMT"/> </widget> <packing> @@ -1161,6 +1176,9 @@ <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Network Device Select</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1366,6 +1384,9 @@ <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Virtual Network Select</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1541,6 +1562,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">MAC Address Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> diff -r a52478052b5c src/vmm-console.glade --- a/src/vmm-console.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-console.glade Mon Jul 30 11:31:22 2007 -0400 @@ -471,6 +471,9 @@ <property name="has_frame">True</property> <property name="invisible_char">*</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Password Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> diff -r a52478052b5c src/vmm-create-net.glade --- a/src/vmm-create-net.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-create-net.glade Mon Jul 30 11:31:22 2007 -0400 @@ -615,6 +615,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Net Name Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -817,6 +820,9 @@ <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> <property name="width_chars">20</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Network Range</atkproperty> + </accessibility> <signal name="changed" handler="on_net_network_changed" last_modification_time="Wed, 28 Mar 2007 21:49:47 GMT"/> </widget> <packing> @@ -1418,6 +1424,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Start Address</atkproperty> + </accessibility> <signal name="changed" handler="on_net_dhcp_start_changed" last_modification_time="Thu, 29 Mar 2007 22:51:47 GMT"/> </widget> <packing> @@ -1440,6 +1449,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">End Address</atkproperty> + </accessibility> <signal name="changed" handler="on_net_dhcp_end_changed" last_modification_time="Thu, 29 Mar 2007 22:51:53 GMT"/> </widget> <packing> @@ -1664,6 +1676,9 @@ <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Physical Network</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> diff -r a52478052b5c src/vmm-create.glade --- a/src/vmm-create.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-create.glade Mon Jul 30 12:17:50 2007 -0400 @@ -671,6 +671,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Name Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1008,6 +1011,9 @@ mipsel</property> mipsel</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Architecture Select</atkproperty> + </accessibility> <signal name="changed" handler="on_cpu_architecture_changed" last_modification_time="Tue, 20 Feb 2007 03:29:44 GMT"/> </widget> <packing> @@ -1487,6 +1493,9 @@ mipsel</property> <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">ISO Location Field</atkproperty> + </accessibility> </widget> <packing> <property name="padding">0</property> @@ -1615,6 +1624,9 @@ mipsel</property> <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Media Path Select</atkproperty> + </accessibility> <signal name="changed" handler="on_cd_path_changed" last_modification_time="Wed, 23 Aug 2006 20:46:09 GMT"/> </widget> <packing> @@ -1724,6 +1736,9 @@ mipsel</property> <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">OS Type Select</atkproperty> + </accessibility> <signal name="changed" handler="on_os_type_changed"/> </widget> <packing> @@ -1740,6 +1755,9 @@ mipsel</property> <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">OS Variant Select</atkproperty> + </accessibility> <signal name="changed" handler="on_os_variant_changed"/> </widget> <packing> @@ -2200,6 +2218,9 @@ mipsel</property> <property name="add_tearoffs">False</property> <property name="has_frame">True</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Install URL Field</atkproperty> + </accessibility> </widget> </child> </widget> @@ -2231,6 +2252,9 @@ mipsel</property> <property name="add_tearoffs">False</property> <property name="has_frame">True</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Kickstart Field</atkproperty> + </accessibility> </widget> </child> </widget> @@ -2752,6 +2776,9 @@ mipsel</property> <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Partition Field</atkproperty> + </accessibility> </widget> <packing> <property name="padding">0</property> @@ -2804,6 +2831,9 @@ mipsel</property> <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">File Location Field</atkproperty> + </accessibility> <signal name="changed" handler="on_storage_file_address_changed" last_modification_time="Tue, 12 Sep 2006 21:28:45 GMT"/> </widget> <packing> @@ -2899,6 +2929,9 @@ mipsel</property> <property name="snap_to_ticks">True</property> <property name="wrap">False</property> <property name="adjustment">500 0 4000000 100 500 500</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">File Size Select</atkproperty> + </accessibility> <signal name="changed" handler="on_storage_file_size_changed" last_modification_time="Thu, 10 Aug 2006 19:19:04 GMT"/> </widget> </child> @@ -3239,6 +3272,9 @@ mipsel</property> <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Network Device Select</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -3444,6 +3480,9 @@ mipsel</property> <property name="visible">True</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Network Select</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -3619,6 +3658,9 @@ mipsel</property> <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">MAC Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -4216,6 +4258,9 @@ mipsel</property> <property name="snap_to_ticks">False</property> <property name="wrap">False</property> <property name="adjustment">249 50 32000 5 10 10</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Max Mem Select</atkproperty> + </accessibility> <signal name="value_changed" handler="on_create_memory_max_value_changed" last_modification_time="Tue, 12 Sep 2006 21:11:37 GMT"/> </widget> </child> @@ -4253,6 +4298,9 @@ mipsel</property> <property name="snap_to_ticks">False</property> <property name="wrap">False</property> <property name="adjustment">244 50 32000 5 10 10</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Startup Mem Select</atkproperty> + </accessibility> </widget> </child> </widget> @@ -4289,6 +4337,9 @@ mipsel</property> <property name="snap_to_ticks">True</property> <property name="wrap">False</property> <property name="adjustment">1 1 32 1 2 2</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">VCPU Select</atkproperty> + </accessibility> </widget> </child> </widget> diff -r a52478052b5c src/vmm-details.glade --- a/src/vmm-details.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-details.glade Mon Jul 30 11:31:22 2007 -0400 @@ -338,6 +338,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Name Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -500,6 +503,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">UUID Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1175,6 +1181,9 @@ <property name="snap_to_ticks">False</property> <property name="wrap">False</property> <property name="adjustment">1 1 32 1 2 2</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">VCPU Select</atkproperty> + </accessibility> <signal name="changed" handler="on_config_vcpus_changed" last_modification_time="Fri, 22 Sep 2006 15:41:27 GMT"/> </widget> <packing> @@ -1592,6 +1601,9 @@ <property name="snap_to_ticks">False</property> <property name="wrap">False</property> <property name="adjustment">50 50 32000 5 10 10</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Max Memory Select</atkproperty> + </accessibility> <signal name="changed" handler="on_config_maxmem_changed" last_modification_time="Mon, 13 Nov 2006 17:34:48 GMT"/> </widget> <packing> @@ -1737,6 +1749,9 @@ <property name="snap_to_ticks">False</property> <property name="wrap">False</property> <property name="adjustment">50 50 32000 5 10 10</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Memory Select</atkproperty> + </accessibility> <signal name="changed" handler="on_config_memory_changed" last_modification_time="Fri, 01 Sep 2006 19:08:14 GMT"/> </widget> <packing> @@ -2512,6 +2527,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">MAC Address Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> diff -r a52478052b5c src/vmm-host.glade --- a/src/vmm-host.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-host.glade Mon Jul 30 11:31:22 2007 -0400 @@ -866,6 +866,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Net Name</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -887,6 +890,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Net UUID</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -908,6 +914,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Net Device</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1244,6 +1253,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Network Range</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1265,6 +1277,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Start Address</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1286,6 +1301,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">End Address</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1688,6 +1706,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Storage Location</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -1737,6 +1758,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Storage Name</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> diff -r a52478052b5c src/vmm-manager.glade --- a/src/vmm-manager.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-manager.glade Mon Jul 30 11:31:22 2007 -0400 @@ -396,6 +396,9 @@ Inactive virtual machines</property> Inactive virtual machines</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">View Select</atkproperty> + </accessibility> <signal name="changed" handler="on_vm_view_changed" last_modification_time="Tue, 10 Oct 2006 20:44:44 GMT"/> </widget> <packing> diff -r a52478052b5c src/vmm-modify-file-storage.glade --- a/src/vmm-modify-file-storage.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-modify-file-storage.glade Mon Jul 30 11:31:22 2007 -0400 @@ -215,6 +215,9 @@ <property name="snap_to_ticks">False</property> <property name="wrap">False</property> <property name="adjustment">1 0 100 1 10 10</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Storage Size Select</atkproperty> + </accessibility> </widget> <packing> <property name="padding">0</property> @@ -231,6 +234,9 @@ TB</property> TB</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Size Type</atkproperty> + </accessibility> </widget> <packing> <property name="padding">0</property> diff -r a52478052b5c src/vmm-open-connection.glade --- a/src/vmm-open-connection.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-open-connection.glade Mon Jul 30 11:31:22 2007 -0400 @@ -163,6 +163,9 @@ <property name="has_frame">True</property> <property name="invisible_char">â?¢</property> <property name="activates_default">False</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Hostname Field</atkproperty> + </accessibility> </widget> <packing> <property name="left_attach">1</property> @@ -181,6 +184,9 @@ Remote tunnel over SSH</property> Remote tunnel over SSH</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Connection Select</atkproperty> + </accessibility> <signal name="changed" handler="on_connection_changed" last_modification_time="Wed, 11 Jul 2007 22:34:03 GMT"/> </widget> <packing> @@ -284,6 +290,9 @@ QEMU</property> QEMU</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Hypervisor Select</atkproperty> + </accessibility> <signal name="changed" handler="on_type_hypervisor_changed" last_modification_time="Mon, 19 Feb 2007 22:04:06 GMT"/> </widget> <packing> diff -r a52478052b5c src/vmm-preferences.glade --- a/src/vmm-preferences.glade Wed Aug 01 18:02:53 2007 -0400 +++ b/src/vmm-preferences.glade Mon Jul 30 11:31:22 2007 -0400 @@ -174,6 +174,9 @@ <property name="snap_to_ticks">False</property> <property name="wrap">False</property> <property name="adjustment">5 1 60 1 5 5</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Status Interval</atkproperty> + </accessibility> <signal name="value_changed" handler="on_stats_update_interval_changed" last_modification_time="Mon, 03 Apr 2006 15:27:12 GMT"/> </widget> <packing> @@ -250,6 +253,9 @@ <property name="snap_to_ticks">False</property> <property name="wrap">False</property> <property name="adjustment">10 10 300 1 5 5</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">History Samples</atkproperty> + </accessibility> <signal name="value_changed" handler="on_stats_history_length_changed" last_modification_time="Mon, 03 Apr 2006 15:27:39 GMT"/> </widget> <packing> @@ -391,6 +397,9 @@ On mouse over</property> On mouse over</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Grab Keyboard</atkproperty> + </accessibility> <signal name="changed" handler="on_console_keygrab_changed" last_modification_time="Mon, 06 Nov 2006 19:31:31 GMT"/> </widget> <packing> @@ -411,6 +420,9 @@ For all domains</property> For all domains</property> <property name="add_tearoffs">False</property> <property name="focus_on_click">True</property> + <accessibility> + <atkproperty name="AtkObject::accessible_name" translatable="yes">Auto Console</atkproperty> + </accessibility> <signal name="changed" handler="on_console_popup_changed" last_modification_time="Mon, 06 Nov 2006 19:41:11 GMT"/> </widget> <packing>
_______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
