Re: [PATCH] check the existing file in virt-install

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Masayuki Sunou wrote:
> Hi
> 
> When the existing file is specified with virt-install, the file is
> compulsorily overwrited.
> Therefore the important file may be overwrited when a user makes a typo.
> 
> This patch fixes so that virt-install displays warning message when
> the existing file is specified.
> 
> Signed-off-by: Masayuki Sunou <fj1826dm@xxxxxxxxxxxxxxxxx>
> 
> Thanks,
> Masayuki Sunou.

Patch looks fine to me. A small nitpick though: I'd change "Do you
really want to use the disk?" to "Do you really want to use this file?"
and add a newline at the start of the line to prevent it from wrapping.

- Cole

-- 
Cole Robinson
crobinso@xxxxxxxxxx

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Index of Archives]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux