Re: [PATCH] virtinst error message improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Cole Robinson wrote:
Hugh Brock wrote:
Cole Robinson wrote:
Cole Robinson wrote:

Hi all,

Attached is a patch that cleans up and improves some error reporting in virtinst. Includes error checking for setting memory and vcpu, improved install location and disk location errors, and a couple other fixes.

Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>

Thanks,
Cole



I managed to slip in a small bug when tidying up the patch to send out. I thought I tested it but apparently not! Attached is the fixed patch.

Thanks, Cole


This looks good on first glance; I'll test it this afternoon.

One of the BZs we had on the guest name issue requested that we allow "." in guest names as well. Does anyone know if that is legal for Xen? If so, we should add that character to the regex as well.

Thanks,
--Hugh


I verified that xen doesn't complain about a '.' in the guest name, so I added that to the patch and changed a few error messages to be more clear.

Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>

Thanks,
Cole



Applied...
--Hugh

--
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock@xxxxxxxxxx    | virtualization library http://libvirt.org

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Index of Archives]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux