Hugh Brock wrote:
Needed to change "guest.os_type" to "self._guest.os_type" here and below, works fine with that change.
Your comment was actually at the removed portion of the code so I was confused for a minute, but yes, definitely change that.
NIT: Seems silly to copy the entire self._guest object here merely so you can hang onto the name. Why not just "name = self._guest.get_name()" followed later by "self._guest.name = name"?
Whoops, good call.
Otherwise looks pretty good. If you agree to the changes above I will apply it.
I agree, apply at will. :) Thanks, Cole -- Cole Robinson crobinso@xxxxxxxxxx _______________________________________________ et-mgmt-tools mailing list et-mgmt-tools@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/et-mgmt-tools
