Masayuki Sunou wrote:
Hi
Although the maximum number of VCPU is different in each architecture, the
maximum number of VCPU is 32 in virt-manager.
ex:
x86 - the maximum number of VCPU is 32
IA64 - the maximum number of VCPU is 64
This patch fixes it.
Signed-off-by: Masayuki Sunou <fj1826dm@xxxxxxxxxxxxxxxxx>
Thanks,
Masayuki Sunou.
Hmm, this is good, but I'm inclined to think it would be better to put a
getMaxVcpus() call in connection.py and isolate the "check the
connection type and either call getMaxVcpus or arbitrarily return '32'"
there (so we don't repeat the code in two places). Also, it looks to me
like "Xen" is the default in xen_unified.c, at least in current libvirt
code, so you shouldn't need to supply "Xen" to the getMaxVcpus call. Can
you redo the patch along these lines?
Thanks so much,
--Hugh
--
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock | virt-manager http://virt-manager.org
hbrock@xxxxxxxxxx | virtualization library http://libvirt.org
