On Wed, Jun 13, 2007 at 05:18:05PM -0400, Hugh Brock wrote: > Cole Robinson wrote: > >The error message that pops up when the user tries to enter an invalid > >guest name doesn't correctly list valid name characters (it was missing > >the '-'). > > > >Thanks, > >Cole > > > > > Applied, thanks! > > However: What we really want to do here is stop validating this stuff in > virt-manager at all. We have validation both in virt-manager and > virtinst and in a couple of places it disagrees... grr... What we should > really do is abstract this kind of validation into virtinst/util.py I > think, that way we have only one regex. Yes, we shoiuld have a 'virtinst/validation.py' module with functions for validating all the common things we check - virt-install is probably the best source for taking the validation code from - Fujitsu folks have put alot of effort into making sure the command line tools do full validation. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
