On Fri, Jun 08, 2007 at 02:16:22PM +0900, Masayuki Sunou wrote: > Hi, Dan > > Thank you for reviewing. > > > The console code already has support for auto-connecting to the console > > with retries. When popping up the console it will retry after 125 ms, > > 250ms, 500ms, 1s, 2s and then every 2s upto 10 times. > > > Oops, I forgot that the connection to the console is retried in "console.py". > > > > I'm interested to know what this isn't working for you ? Check the log > > file /root/.virt-manager/virt-manager.log which should show you messages > > every time it tries to open the console. The code for re-trying the console > > connection is in src/virtManager/console.py in the try_login() method. > > > I thought that the following is the problem. > > ---------------------------------------------------------------------- > In finish() of "create.py", the port number of VNC become -1. > When "Status monitoring" is short, the port number of VNC is updated > in a short time, but, when "Status monitoring" is long, the port number > of VNC is not updated for a long time. > Because the XML data cached in "domain.py" is updated only in tick(). > ---------------------------------------------------------------------- Ahh that does make sense now. > I remake the patch. > This patch only clears XML in get_graphics_console(), and the connection > to the console is not retried in "create.py". > So, by applying this patch, the XML data is cleared by retrying in "console.py" > even when "Status monitoring" is long, and the port number of VNC is updated. > (Because retrying in "console.py" calls get_graphics_console()) A bit of a hack clearing the cache XML here, but probably the best way to do it anyway. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
