Re: [et-mgmt-tools] [PATCH] [RESEND] Fix continue to install Windows

[Nobuhiro Itou <fj0873gn@xxxxxxxxxxxxxxxxx>]

Hi,

Would you give me a comment on this patch?
If not, please apply it.

> I can't continue to install Windows HVM domain after first restart.
> After the restarting, /dev/cdrom (or ISO path) has not been attached to the domain.
> The attached patch solves this problem.
> 
> Signed-off-by: Nobuhiro Itou <fj0873gn@xxxxxxxxxxxxxxxxx>


Thanks,
Nobuhiro Itou.


diff -r 797e92fd5e0d virtinst/FullVirtGuest.py
--- a/virtinst/FullVirtGuest.py Thu May 31 14:20:33 2007 -0400
+++ b/virtinst/FullVirtGuest.py Fri Jun 01 10:57:49 2007 +0900
@@ -227,8 +227,10 @@ class FullVirtGuest(Guest.XenGuest):
         ret = ""
         count = 0
         for d in self.disks:
+            backup_path = None
             if d.transient and not install:
                 if d.device == Guest.VirtualDisk.DEVICE_CDROM:
+                    backup_path = d.path
                     d.path = None
                 else:
                     continue
@@ -242,5 +244,7 @@ class FullVirtGuest(Guest.XenGuest):
                    count += 1
                disknode = "%(disknode)s%(dev)c" % { "disknode": self.disknode, "dev": ord('a') + count }
             ret += d.get_xml_config(disknode)
+            if backup_path:
+                d.path = backup_path
             count += 1
         return ret
diff -r 797e92fd5e0d virtinst/Guest.py
--- a/virtinst/Guest.py Thu May 31 14:20:33 2007 -0400
+++ b/virtinst/Guest.py Fri Jun 01 10:59:08 2007 +0900
@@ -625,10 +625,11 @@ class Guest(object):
         else:
             action = "restart"

+        osblob_install = install
         if disk_boot:
-            install = False
-
-        osblob = self._get_osblob(install)
+            osblob_install = False
+
+        osblob = self._get_osblob(osblob_install)
         if not osblob:
             return None