Hi, Dan Thanks for your comment. > It will prove unreliable in practice, because even if you > fix a particular guest on port 5905, any other guest doing dynamic VNC port > assignment may choose this port before the hardcoded guest starts. This situation is surely thought. But, I think that problem is solved if it performs a repetition check of a port number in virt-inst. When it is this situation, at first, examine the port number that all other guests use when it starts a guest. Next, If the port number is fixed and repetition, output a message. [e.g."Repetition. Set a different port number."] (However, there is not a function setting a port for an existing guest now. If it is necessary at the same time, I make 'check of repetition' and 'function setting a port for an existing guest'.) > It is not going to be easy for virt-manager to do validation of this port number > either, since in the near future virt-manager may well be running remotely > from the host. If it adds a revision to libvirt side to get a port number from the information that acquired from xend, the acquisition of a port number will be easy. > this is a very small niche usecase I do not think so. and I think that there is a person to need surely. Because, I think that it can perform the prevention / maintenance by the pair of guest and port-number are managed. For example, The person who thinks about maintenance for the port which opened out had better be a fixed port number. If it does't know whether it has already opened or it will open out from now on, it will become difficult to deal with possibility of attack to an opening port. Therefore, the user who wants to open only a specific port for a firewall needs to fixed port number. And, even if it can get a dynamic port from remote connection in the future, he needs a fixed port number at the time of remote connection too, because he wants to connection with only a specific port. From these, I think the problem is bigger opening a port at random than repetition of a port number. That is why at first I make a function of the fixed port number at the time of making guest. Thanks, Shigeki Sakamoto. > On Fri, May 18, 2007 at 07:05:13PM +0900, S.Sakamoto wrote: > > Hi, > > > > The attached patch adds VNC-Port setting when virt-manager creates VM. > > The user can choose whether a VNC-Port is fixed or automatic setup. > > I don't think we want to expose ability to specify a fixed VNC port numbers > in virt-manager. It will prove unreliable in practice, because even if you > fix a particular guest on port 5905, any other guest doing dynamic VNC port > assignment may choose this port before the hardcoded guest starts. It is > not going to be easy for virt-manager to do validation of this port number > either, since in the near future virt-manager may well be running remotely > from the host. Finally, any one using virt-manager for management of guests > never needs to know the port number, since virt-manager will always query > it from the XML, so this is a very small niche usecase & I don't think it > is worthwhile adding an extra step in the new VM wizard just for this > capability. > > Regards, > Dan. > -- > |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| > |=- Perl modules: http://search.cpan.org/~danberr/ -=| > |=- Projects: http://freshmeat.net/~danielpb/ -=| > |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| > > _______________________________________________ > et-mgmt-tools mailing list > et-mgmt-tools@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/et-mgmt-tools >
