Takahashi Tomohiro wrote: > Hi, > > The virt-manager specify the Domain's disk sources. > But the virt-manager doesn't check that the disk sources are > conflicted among the other domains. > > The attached patch resolve this issue in the following way: > > 1) Count that the making domian's disk src is already use > the exists domain's disk source. > 2) if disk src is already use, confirmation message. > Disk "/dev/xxx" is already in use by another guest! > Do you really want to use the disk ? > 3) if select yes then leave disk source as it is, > else(no) specify disk source again. > > Signed-off-by: Tomohiro Takahashi <takatom@xxxxxxxxxxxxxx> > > Thanks, > Tomohiro Takahashi. > I have applied this with a minor change: you can use gtk.RESPONSE_YES for the response constant, rather than creating your own. It would be nice, however, to tell the user which guest is using the disk? Maybe another patch that adds that capability would be good. Thanks, --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock@xxxxxxxxxx | virtualization library http://libvirt.org
