Tatsuro Enokura wrote: > Hi, Dan > > Daniel P. Berrange wrote: >>> The virt-install command specify the Domain's disk sources. >>> But the virt-install command doesn't check that the disk sources are >>> conflicted among the other domains. >>> >>> The attached patch resolve this issue in the following way: >>> >>> 1) Count that the making domian's disk src is already use >>> the exists domain's disk source. >>> 2) if count > 0, print confirmation message. >>> 3) if type yes then leave disk source as it is, >>> else ask disk source again. >>> >>> I am making a patch for virt-manager about this issue. >> If you the non-interactive bit of code into the virtinst/Guest.py module >> in the VirtualDisk class, we can share 95% of it between both virtinstall >> & virt-manager. > > Thank you for your suggestion. > I rewrite the patch. > > Signed-off-by: Tatsuro Enokura <fj7716hz@xxxxxxxxxxxxxxxxx> > This looks fine, I have committed it. --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock@xxxxxxxxxx | virtualization library http://libvirt.org
