Nobuhiro Itou wrote:
Hi, Hugh
Two issues here:
1. The whole "restart the guest automatically" feature in virt-install
is a bit of a hack, and we are contemplating removing it altogether. The
problem is that virt-install has no real way of knowing whether the
guest that just shut down is really waiting to be rebooted, or is in
fact a failed install that the user would not want restarted anyway.
Exactly.
But, the "restart" hack is also true to help the user.
Especially, the domain cannot be completely installed about Windows etc.
with the reboot during the installation if it doesn't start automatically.
Please keep autorestart function like --autorestart.
Having said this, as long as the "restart" hack is still there, I guess
I have no problem reconnecting the console as well.
2. Minor nit: instead of swallowing the error like
+ except OSError, (errno, msg):
+ print __name__, "waitpid:", msg
why not go ahead and raise a RuntimeError (and log the message) or
something similar?
Okey.
How about this correction?
Thanks,
Nobuhiro Itou.
Thanks! I am working on fixing the auto-restart feature now, the console
connection part isn't working properly at the moment. Once I have fixed
it, I'll apply your patch as well.
Take care,
--Hugh
--
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock | virt-manager http://virt-manager.org
hbrock@xxxxxxxxxx | virtualization library http://libvirt.org
