On Mon, 12 Mar 2007 17:31:40 -0400 Hugh Brock wrote: > Saori Fukuta wrote: > > Hi, > > > > I have no reply about following patch. > > So, I made it again for the current virt-install. > > > > I am looking forward to hearing your comment. > > If everything is OK, please apply it. > > > > On Tue, 06 Mar 2007 18:09:01 +0900 Saori Fukuta wrote: > > > >> So, here's what I'm going to suggest. I add two functions that check > >> the length of values, and if the value type is string I defined them > >> as a callback options . > >> They are called by following option: > >> long option (short option) > >> --name (-n) > >> --uuid (-u) > >> --file (-f) > >> --mac (-m) > >> --bridge (-b) > >> --connect > >> --cdrom (-c) > >> --os-type > >> --os-variant > >> --arch > >> --location (-l) > > add "--keymap" > > > >> There is one exception. "--extra-args" doesn't call, because the option > >> has default value and that is ''. > > > > Thanks Saori-san, patch applied. Appears to work perfectly. > --Hugh Thank you Hugh. >From now on, we can use this callback when value type of option argument is string. :-) Saori.