On Wed, Feb 28, 2007 at 05:47:29PM +0900, Saori Fukuta wrote:
> Hi,
>
> I can't install with current virt-install ( version: 0.101.0 ).
>
> I think the cause is the difference in following:
> getting OS type from libvirt : Xen (capital letter)
> check string at virt-install : xen (small letter)
> So, I fix the string "xen" to "Xen" and I can install.
>
> But, I worry about that libvirt has some return code.
> e.g.)
> xen_internal.c ... return("Xen");
> xend_internal.c ... return("XenDaemon");
> xm_internal.c ... return ("XenXM");
> Is that all right?
Not entirely right - although in this scenario at least we wil only ever
see the first string returned, because the xen_internal.c takes priority
over everything else.
> Index: virt-install ( version: 0.101.0 )
> ===================================================================
> --- virt-install 2007-02-28 22:49:27.000000000 +0900
> +++ virt-install.new 2007-03-01 02:25:30.000000000 +0900
> @@ -371,7 +371,7 @@ def main():
> conn = libvirt.open(options.connect)
> type = None
> # check to ensure we're really on a xen kernel
> - if conn.getType() == "xen":
> + if conn.getType() == "Xen":
> type = "xen"
> check_xen()
>
> @@ -381,7 +381,7 @@ def main():
>
> # first things first, are we trying to create a fully virt guest?
> hvm = False
> - if conn.getType() == "xen":
> + if conn.getType() == "Xen":
> if virtinst.util.is_hvm_capable():
> hvm = options.fullvirt
> if hvm is None:
I'll have to investigate why I didn't see a failure during testing when I
did the initial release, but in principle this is fine.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
