Hi, Dan
On Wed, 21 Feb 2007 14:05:19 +0000 "Daniel P. Berrange" wrote:
> On Wed, Feb 21, 2007 at 12:09:02PM +0900, Saori Fukuta wrote:
> > Hi,
> >
> > The attached patch adds to check the domain name that must not be
> > numeric only.
> >
> > Signed-off-by: Saori Fukuta <fukuta.saori@xxxxxxxxxxxxxx>
>
> Looks good, will apply.
By the way, I find a slight mistake here.
How about this for a message?
Signed-off-by: Saori Fukuta <fukuta.saori@xxxxxxxxxxxxxx>
Thanks,
Saori Fukuta.
Index: virtinst/Guest.py (python-virtinst-0.100.0)
===================================================================
--- Guest.py 2007-02-21 11:04:43.000000000 +0900
+++ Guest.py.msg 2007-02-23 11:13:07.000000000 +0900
@@ -207,7 +207,7 @@ class Guest(object):
if re.match("^[a-zA-Z0-9_]*$", val) == None:
raise ValueError, "Domain name must be alphanumeric or _"
if len(val) > 50:
- raise ValueError, "Domain name must be less than 50 characters"
+ raise ValueError, "Domain name must be less or equal 50 characters"
if type(val) != type("string"):
raise ValueError, "Domain name must be a string"
self._name = val
