On Mon, 19 Jun 2023 at 15:31, Coiby Xu <coxu@xxxxxxxxxx> wrote: > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=2121912 > > Now there is a growing user base to use the kexec reboot and it's > desirable to make the kexec-tools package more modular. > > This patch splits current kexec-tools into two sub-packages kexec-tools > and kdump-tools. Now kexec-tools merely provides /usr/sbin/kexec and the > remaining features go into kdump-tools. > > "dnf repoquery --whatrequires kexec-tools" shows the following packages > requires kexec-tools, > - abrt-addon-vmcore > - anaconda-install-env-deps > - cockpit-kdump > - dracut-kiwi-oem-dump > - realtime-setup > - retrace-server > > For those packages that need kdump, the dependency needs to point to > the new kdump-tools package instead. > > Cc: fedora-devel@xxxxxxxxxxxxxxxxxxxxxx > Cc: Dusty Mabe <dustymabe@xxxxxxxxxx> > Cc: crash-catcher-owner@xxxxxxxxxxxxxxxxxxxxxx > CC: anaconda-devel@xxxxxxxxxxxxxxxxxxxxxxx > Cc: Martin Pitt <mpitt@xxxxxxxxxx> > Cc: kiwi-images@xxxxxxxxxxxxxxxx > Cc: Clark Williams <williams@xxxxxxxxxx> > Cc: Matěj Grabovský <mgrabovs@xxxxxxxxxx> > Suggested-by: Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> > Signed-off-by: Coiby Xu <coxu@xxxxxxxxxx> > --- > kexec-tools.spec | 80 +++++++++++++++++++++++++++++------------------- > 1 file changed, 48 insertions(+), 32 deletions(-) > > diff --git a/kexec-tools.spec b/kexec-tools.spec > index 360b6c5d..6e78f6d3 100644 > --- a/kexec-tools.spec > +++ b/kexec-tools.spec > @@ -5,9 +5,10 @@ > > Name: kexec-tools > Version: 2.0.26 > -Release: 7%{?dist} > +Release: 8%{?dist} > License: GPLv2 > Summary: The kexec/kdump userspace component > +Obsoletes: kexec-tools < 2.0.26-8 > > Source0: http://kernel.org/pub/linux/utils/kernel/kexec/%{name}-%{version}.tar.xz > Source1: kdumpctl > @@ -56,33 +57,6 @@ Source109: dracut-early-kdump-module-setup.sh > Source200: dracut-fadump-init-fadump.sh > Source201: dracut-fadump-module-setup.sh > > -%ifarch ppc64 ppc64le > -Requires(post): servicelog > -Recommends: keyutils > -%endif > -Requires(pre): coreutils sed zlib > -Requires: dracut >= 058 > -Requires: dracut-network >= 058 > -Requires: dracut-squash >= 058 > -Requires: ethtool > -Requires: util-linux > -# Needed for UKI support > -Recommends: binutils > -Recommends: grubby > -Recommends: hostname > -BuildRequires: make > -BuildRequires: zlib-devel elfutils-devel glib2-devel bzip2-devel ncurses-devel bison flex lzo-devel snappy-devel libzstd-devel > -BuildRequires: pkgconfig intltool gettext > -BuildRequires: systemd-rpm-macros > -BuildRequires: automake autoconf libtool > -%ifarch %{ix86} x86_64 ppc64 ppc s390x ppc64le > -Obsoletes: diskdumputils netdump kexec-tools-eppic > -%endif > - > -%ifnarch s390x > -Requires: systemd-udev%{?_isa} > -%endif > - > #START INSERT > > # > @@ -117,6 +91,42 @@ normal or a panic reboot. This package contains the /sbin/kexec > binary and ancillary utilities that together form the userspace > component of the kernel's kexec feature. > > +%package -n kdump-tools Hi, I still can not resist adding a comment about the naming, although different distribution will not cause pkg name confliction, it still sounds strange to me. Debian/Ubuntu use kdump-tools: https://manpages.debian.org/unstable/kdump-tools/kdump-tools.5.en.html Suse use kdumptool: (but seems the tool is really a tool instead of service related, not sure where is the initrd generating code) https://www.unix.com/man-page/suse/8/kdumptool/ So it would be better to have a name which can be easily differentiated from above two although not a must. BTW another thing to think is probably we should split the real tooling to estimate and other stuff out of service manipulation in kdumpctl? Anyway I have no strong opinion, just leave here about the thoughts to discuss. Thanks Dave _______________________________________________ Anaconda-devel mailing list -- anaconda-devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to anaconda-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/anaconda-devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
