On Thu, Jul 9, 2020 at 5:33 AM Vendula Poncova <vponcova@xxxxxxxxxx> wrote: > > On Thu, Jul 9, 2020 at 4:26 AM Chris Murphy <lists@xxxxxxxxxxxxxxxxx> wrote: >> >> Hi, >> >> I am confused. For default partitioning, the idea is to no longr >> create a swap partition, instead there will be both zram-generator and >> zram-generator-defaults packages, which will cause a swap on >> /dev/zram0 to be created during early boot. >> >> When I look in https://pagure.io/fedora-kickstarts all of the ks files >> that contain 'autopart' also contain '--noswap'. Yet Workstation >> edition and others, do have a swap partition created. Suggestions? >> > > Hi, > > the kickstart files from fedora-kickstarts are used for Fedora release images. They don't define the default partitioning of new installations. Is there a problem with the partitioning on these images? > > Default partitioning of new installations is defined in Anaconda: > https://github.com/rhinstaller/anaconda/blob/master/data/anaconda.conf#L16 OK, that about sums up my confusion. :) > The change seems to be approved. Can I open a pull request for the changes in the Anaconda configuration files? Yes please, that will certainly save me more embarrassment. One item I haven't worked through yet is how 'inst.zram' should inhibit the zram-generator. The generator runs during early boot. My current thinking is 'inst.zram' can just 'systemctl stop swap-create@zram0.service' since it will exist already. In that case it could optionally be renamed to 'inst.nozram'. What do you think? I think the timing of the changes isn't very critical. If the release images have zram-generator first, it will run sooner and the Anaconda implementation will fail (error messages in logs, but otherwise non-fatal). Whereas if the Anaconda implementations go away first, the lack of swap on zram in low memory situations might cause problems. -- Chris Murphy _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
