On Thu, Jun 19, 2014 at 03:03:26PM +0800, Junxiao Bi wrote: > On 06/17/2014 10:53 PM, Peter Jones wrote: > > On Tue, Jun 17, 2014 at 09:47:22AM +0800, Junxiao Bi wrote: > >> Cc: Peter Jones <pjones@xxxxxxxxxx> > > These three patches all look, upon visual inspection, to be fine. > > Before we can merge them, we'll need 2 things: > > > > 1) they all need to be proceeded with test cases that fail before > > applying the patch and succeed afterwards > > 2) I'll need you to send them as actual "git format-patch" output, not > > quoted text. > Peter, double confirm of this, do you need me create test cases for the > three patches, or just need the grub.conf diff before and after applying > the patch? Any patches to grubby need to include patches to make "make test" check those changes. -- Peter _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list