Hi, Cleber Rosa <crosa@xxxxxxxxxx> writes: > Because dirname() may modify the path. See: > > http://www.kernel.org/doc/man-pages/online/pages/man3/dirname.3.html > > This fixes a segfault found while manually testing grubby on RHEL 5. > > This reverts commit 54ff9d923f1dd90dde81e0e90e9448fdc52044c4. Ok, you are right in this, it looks like I had read the dirname() manpage without paying attention to that detail. This introduces back a memory leak -- which I know it is not a huge issue provided that Grubby is not a long-running process. Nevertheless, going through the code and fixing those would be desirable in the long term (IMHO). Regards, -- Adrian Perez <aperez@xxxxxxxxxx> - Sent from my toaster Igalia - Free Software Engineering
Attachment:
pgpyQFolUKXND.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
