Re: [PATCH lorax/master 7/7] remove dmidecode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20.06.2012 11:17, Moray Henderson wrote:

>> -----Original Message-----
>> From: Will Woods [mailto:wwoods@xxxxxxxxxx]
>> Sent: 20 June 2012 01:06
>>
>> current anaconda-dracut doesn't need this; drop it from the runtime.
>> ---
>>  share/runtime-install.tmpl |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/share/runtime-install.tmpl b/share/runtime-install.tmpl
>> index 90c1a1c..568f799 100644
>> --- a/share/runtime-install.tmpl
>> +++ b/share/runtime-install.tmpl
>> @@ -45,7 +45,7 @@ installpkg rpcbind
>>  ## required for dracut
>>  installpkg kbd kbd-misc
>>  ## required for anaconda-dracut (img-lib etc.) -installpkg tar xz
>> dmidecode curl
>> +installpkg tar xz curl
>>
>>  ## basic system stuff
>>  installpkg systemd-sysv systemd-units
>> --
>> 1.7.10.2
> 
> I sometimes use dmidecode to do system-specific stuff in kickstart %post:
> 
>   if dmidecode -s system-manufacturer | grep -q VMware; then
>       chkconfig smartd off
>   fi

This seems wrong. That's something which is common to all emulators, not
just VMWare. We probably need a function is_vm which will agglomerate
checks for VM. What are other systems you check for? Other than VM,
which are special case we should rather check for specific devices
present since system ID fiels tell very little about what is really
inside the machine.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux