Re: [PATCH 2/2] Use ksdata.timezone and timezone module instead of anaconda.timezone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----
> On Tue, 2012-06-19 at 10:59 +0200, Vratislav Podzimek wrote:
> > On Mon, 2012-06-18 at 11:17 -0400, Chris Lumens wrote:
> > > > +    try:
> > > > +        with open(os.path.normpath(root +
> > > > "/etc/sysconfig/clock"), "w") as file_:
> > > 
> > > Maybe I'm just being too picky, but there's something about a
> > > name with
> > > a trailing underscore that just makes me cringe.
> > It is what PEP 8 says about names conflicting with Python keywords
> > [1],
> > but I can of course use something else.

I use fobj, as in file object...

> > 
> > Do these patches look good otherwise?
> > 
> Forgot to paste the link.
> 
> [1]
> http://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
> 

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux