Re: [rhel7-alpha2-branch/master PATCH] Handle RUNKS boot argument (#831301)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 13, 2012 at 01:02:32PM -0700, Jesse Keating wrote:
> On 06/13/2012 12:18 PM, David Cantrell wrote:
> >Any reason to not do:
> >
> >if 'SSH_CONNECTION' not in os.environ and "RUNKS" not in flags.cmdline:
> >     prompt_for_ssh()
> >     sys.exit(0)
> 
> I had it that way first, but the double negative with a positive was
> getting a bit confusing.  I thought it was more readable logic wise
> to have it all positives with an else.  I can go either way though,
> I don't really care.

I'd prefer it without the 'pass' block personally since that's a no-op,
but I'm ok with either form.

-- 
David Cantrell <dcantrell@xxxxxxxxxx>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Westford, MA | EST5EDT

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux