Re: [PATCH newui] Network spoke: skip standalone spoke if network is up.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/12/2012 05:57 PM, Brian C. Lane wrote:
On Tue, Jun 12, 2012 at 04:28:20PM +0200, Radek Vykydal wrote:
---
  pyanaconda/ui/gui/spokes/network.py |    9 +++++++++
  1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index 4f81bca..c0e5951 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -996,6 +996,15 @@ class NetworkStandaloneSpoke(StandaloneSpoke):

              threadMgr.add(AnacondaThread(name="AnaPayloadThread", target=payloadInitialize, args=(self.storage, self.data, self.payload)))

+    @property
+    def completed(self):
+        return self.status != _("Not connected")
Isn't there a better way to test for the connection? Comparing to a
translated string seems pretty fragile.


Yes, it seems fragile and bad. I am sending new version of the fix to a-d-l.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux