On Mon, 2012-06-11 at 10:30 -0500, David Marlin wrote:
> This is my second attempt to add ARM support to Lorax. Based on
> feedback and comments from other users we have reworked the patch to
> install all supported ARM kernel variants to create a single install
> tree. This eliminates the platform hash/lookup from the earlier version
> and simplifies the patch a bit.
>
> The patch was made against lorax/master, and tested by applying it to
> lorax-17.25.
Overall the patch looks pretty clean. I'm not sure about the bcj_arch
values, though:
> diff --git a/src/pylorax/__init__.py b/src/pylorax/__init__.py
> index 25cccb3..0606fbd 100644
> --- a/src/pylorax/__init__.py
> +++ b/src/pylorax/__init__.py
> @@ -57,7 +57,10 @@ class ArchData(DataHolder):
> lib64_arches = ("x86_64", "ppc64", "sparc64", "s390x", "ia64")
> bcj_arch = dict(i386="x86", x86_64="x86",
> ppc="powerpc", ppc64="powerpc",
> - sparc="sparc", sparc64="sparc")
> + sparc="sparc", sparc64="sparc",
> + armv5tel="arm", armv7l="arm",
> + armv7hl="armhfp")
> +
> def __init__(self, buildarch):
> self.buildarch = buildarch
> self.basearch = getBaseArch(buildarch)
The 'bcj_arch' dict is for use with the LZMA2 "BCJ filter" compression
feature (as used by mksquashfs). Valid BCJ arches for arm are "arm" and
"armthumb", at least in my version of mksquashfs.
The BCJ filter basically does some address conversion magic on
executable code to make it compress better, so it depends on the
instruction set / address size being used. I'm pretty sure we want "arm"
for all of the arm basearches we care about.
-w
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
