On Fri, Jun 08, 2012 at 10:20:11AM +0200, Vratislav Podzimek wrote: > On Thu, 2012-06-07 at 09:49 -0700, Brian C. Lane wrote: > > On Thu, Jun 07, 2012 at 03:15:06PM +0200, Vratislav Podzimek wrote: > > > + > > > + if anaconda.ksdata.ntp_servers: > > > + ntp.save_servers_to_config(anaconda.ksdata.ntp_servers) > > > + > > > > A couple possible problems with this is that the install could be an > > image install where you don't want to change the host, or a live install > > where someone has (for whatever reason) setup ntp themselves. > > > > Probably a check for flags.imageInstall should skip this. > Okay, I will add it before pushing. But this is a much wider problem > with the whole anaconda script and I believe it should be resolved in a > better way than using such a guard before every action happening. Maybe > having setup_(live|image|standalone)_ks_stuff() functions? I agree, I'm no fan of adding conditionals to everything. I'm not sure how to make this clean. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Attachment:
pgp7j7Q8zxLxR.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
