On Wed, 2012-06-06 at 13:00 -0700, Jesse Keating wrote:
> This keeps the triggering to just the dasd devices, as apparently there
> is a race condition with mpath stuff if we trigger everything this
> early.
> ---
> pyanaconda/storage/dasd.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/pyanaconda/storage/dasd.py b/pyanaconda/storage/dasd.py
> index aceba6d..18d9a86 100644
> --- a/pyanaconda/storage/dasd.py
> +++ b/pyanaconda/storage/dasd.py
> @@ -26,6 +26,7 @@ from pyanaconda.storage.errors import DasdFormatError
> from pyanaconda.storage.devices import deviceNameToDiskByPath
> from pyanaconda.constants import *
> from pyanaconda.flags import flags
> +from pyanaconda.baseudev import *
If you're only using udev_trigger, I'd rather see
from pyanaconda.baseudev import udev_trigger
Obviously it would be a minority case of better practice, but any
improvement is still improvement. Looks good otherwise.
>
> import logging
> log = logging.getLogger("anaconda")
> @@ -86,6 +87,9 @@ class DASD:
> if not iutil.isS390():
> return
>
> + # Trigger udev data about the dasd devices on the system
> + udev_trigger(action="change", sysnamematch="dasd*")
> +
> log.info("Checking for unformatted DASD devices:")
>
> for device in os.listdir("/sys/block"):
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
