Re: [PATCH rhel6-branch] Unmount resources mounted by dracut (#818581)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ack for rhel7-alpha2-branch

On Wed, May 23, 2012 at 03:26:02PM +0200, Radek Vykydal wrote:
> Otherwise it hangs when systemd is trying to umount them
> (Device or resource busy). See also comment in the patch.
> Umount lazily for nfs mounts.
> 
> A bit of history for reference:
> commit a1c759a9524e00356fc952193bb2795dc9c54a18
> commit 8f537d923bf833b1d57504e8e3058535b347fa2f
> commit 37144b9e86e801074fa4ae4656da458fe83f6e07
> commit 93d177b0643a5488b8aa8777e43d4f3c4d57c51d
> ... and now adapt it for systemd.
> 
> Corresponding f17 bug: #824191
> ---
>  pyanaconda/yuminstall.py |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/pyanaconda/yuminstall.py b/pyanaconda/yuminstall.py
> index 0ca534b..9d865a4 100644
> --- a/pyanaconda/yuminstall.py
> +++ b/pyanaconda/yuminstall.py
> @@ -1228,6 +1228,19 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon
>          if not anaconda.mediaDevice and os.path.ismount(self.ayum.tree):
>              isys.umount(self.ayum.tree)
>  
> +        # bug #818581 - mounts from dracut would make systemd hang
> +        # in reboot (Device or resource ebusy) when trying to umount
> +        # them (after NM is stopped)
> +        # - for repo=nfs: dracut nfs mounts /run/install/repo
> +        # - for repo=nfsiso: dracut nfs mounts /run/install/isodir
> +        #                       and iso mounts /run/install/repo
> +        dracut_mounts = ["/run/install/repo", "/run/install/isodir"]
> +        for mp in dracut_mounts:
> +            if os.path.ismount(mp):
> +                log.info("unmounting mount by dracut (lazily) %s" % mp)
> +                iutil.execWithRedirect("umount", ["-l", mp],
> +                                       stdout="/dev/tty5", stderr="/dev/tty5")
> +
>          # clean up rpmdb locks so that kickstart %post scripts aren't
>          # unhappy (#496961)
>          iutil.resetRpmDb()
> -- 
> 1.7.4
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
David Cantrell <dcantrell@xxxxxxxxxx>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Westford, MA | EST5EDT

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux