On Fri, 2012-05-11 at 12:32 -0500, David Lehman wrote:
> An empty list is more reasonable for something treated like a normal
> attribute.
The groups one is wrong -- I'll repost the fixed version shortly.
> ---
> pyanaconda/packaging/yumpayload.py | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/pyanaconda/packaging/yumpayload.py b/pyanaconda/packaging/yumpayload.py
> index 6202a3e..4cd06df 100644
> --- a/pyanaconda/packaging/yumpayload.py
> +++ b/pyanaconda/packaging/yumpayload.py
> @@ -650,6 +650,7 @@ reposdir=%s
> from yum.Errors import RepoError
> from yum.Errors import GroupsError
>
> + groups = []
> with _yum_lock:
> if not self._groups:
> if self.needsNetwork and not hasActiveNetDev():
> @@ -659,9 +660,10 @@ reposdir=%s
> self._groups = self._yum.comps
> except (RepoError, GroupsError) as e:
> log.error("failed to get group info: %s" % e)
> - raise MetadataError(e.value)
> + else:
> + groups = [g.groupid for g in self._groups.get_groups()]
>
> - return [g.groupid for g in self._groups.get_groups()]
> + return groups
>
> def description(self, groupid):
> """ Return name/description tuple for the group specified by id. """
> @@ -713,7 +715,7 @@ reposdir=%s
> try:
> self._packages = self._yum.pkgSack.returnPackages()
> except RepoError as e:
> - raise MetadataError(e.value)
> + log.error("failed to get package list: %s" % e)
>
> return self._packages
>
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
