Re: [PATCH][newui] Simplify the handling of group selection from the software spoke.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2012-04-20 at 15:59 -0400, Chris Lumens wrote:
> > @@ -127,6 +123,7 @@ class SoftwareSelectionSpoke(NormalSpoke):
> >          self._addonStore = self.builder.get_object("addonStore")
> >          self._addonStore.clear()
> >  
> > +        desktops = []
> >          for grp in self.payload.groups:
> >              # Throw out language support groups and critical-path stuff.
> >              if grp.endswith("-support") or grp.startswith("critical-path-"):
> > @@ -142,12 +139,20 @@ class SoftwareSelectionSpoke(NormalSpoke):
> >                  if selected:
> >                      sel = self.builder.get_object("desktopSelector")
> >                      sel.select_iter(itr)
> > +                    self.desktop = grp
> > +
> > +                desktops.append(grp)
> >              else:
> >                  (name, desc) = self.payload.description(grp)
> >                  selected = self.payload.groupSelected(grp)
> >  
> >                  self._addonStore.append([selected, "<b>%s</b>\n%s" % (name, desc), grp])
> >  
> > +        self.selectedGroups = [g.name for g in self.data.packages.groupList
> > +                                if g.name not in desktops]
> > +        self.excludedGroups = [g.name
> > +                                for g in self.data.packages.excludedGroupList]
> > +
> >      # Returns the row in the store corresponding to what's selected on the
> >      # left hand panel, or None if nothing's selected.
> >      def _get_selected_desktop(self):
> 
> I don't think you need to have desktops be a list.  That side of the
> screen should only allow you to have one item selected.

That list of desktops is only for filtering out desktop groups from
selectedGroups, since desktops are handled separately.

Dave

> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux