Re: [PATCH] Remove double quotes in nvram

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 17, 2012 at 09:02:07AM -0500, Mark Hamzy wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=811793
> 
> Double quotes are not needed for the nvram command since it is being
> executed directly and not from bash.  Also, remove any that were
> placed there by previous executions of the code.
> 
> ---
>  pyanaconda/bootloader.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index ffa9632..7e0cb17 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -2019,7 +2019,7 @@ class IPSeriesGRUB2(GRUB2):
>              log.error ("Failed to determine nvram boot device")
>              return
>  
> -        boot_list = buf.strip().split()
> +        boot_list = buf.strip().replace("\"", "").split()
>          log.debug("updateNVRAMBootList: boot_list = %s" % boot_list)
>  
>          buf = iutil.execWithCapture("ofpathname",
> @@ -2036,7 +2036,7 @@ class IPSeriesGRUB2(GRUB2):
>          # Remove all other occurances of it.
>          boot_list = [boot_disk] + filter(lambda x: x != boot_disk, boot_list)
>  
> -        update_value = "boot-device=\"%s\"" % " ".join(boot_list)
> +        update_value = "boot-device=%s" % " ".join(boot_list)
>  
>          rc = iutil.execWithRedirect("nvram", ["--update-config", update_value],
>                                      stdout="/dev/tty5", stderr="/dev/tty5")
> -- 
> 1.7.7.6

Ack.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpvI4TfhOm40.pgp
Description: PGP signature

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux