Re: [f17-branch master] check for valid mountpoints (#748209)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-04-09 at 15:49 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl@xxxxxxxxxx>
> 
> _is_valid_format needs to also check the mountpoints to make sure
> they are valid. Without this it will accept a previously formatted
> EFI fs and let the install continue without having it mounted on
> /boot/efi
> ---
>  pyanaconda/bootloader.py |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

Ack.

> 
> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index e3044cd..06e893d 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -522,6 +522,12 @@ class BootLoader(object):
>                                 % (desc, device.format.type))
>              ret = False
>  
> +        if mountpoints and hasattr(device.format, "mountpoint") \
> +           and device.format.mountpoint not in mountpoints:
> +            self.errors.append(_("%s must be mounted on one of %s.")
> +                               % (desc, ", ".join(mountpoints)))
> +            ret = False
> +
>          log.debug("_is_valid_format(%s) returning %s" % (device.name,ret))
>          return ret
>  


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux