Re: [f17 master 0/2] fixup eject handling (#787461)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  anaconda                    |    5 ++---
>  pyanaconda/constants.py     |    2 ++
>  pyanaconda/installmethod.py |    8 ++++----
>  pyanaconda/iutil.py         |   24 ++++++++++++++++++++++++
>  pyanaconda/yuminstall.py    |   34 +++++++++-------------------------
>  5 files changed, 41 insertions(+), 32 deletions(-)

I think this is the best approach to take, but I have two comments:

(1) You seem to have lapsed into some crazy new coding style with your
parens that we don't seem to be doing anywhere else.

(2) Losing the eject mechanism around the wrong disc error isn't so hot,
but it probably doesn't happen very much anymore.  I bet getting rid of
split media turned this into a very rare case.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux