On Thu, Feb 16, 2012 at 03:50:07PM -0800, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl@xxxxxxxxxx>
>
> Also don't use float to compare 2 numbers. Use Decimal instead.
> ---
> pyanaconda/installclasses/fedora.py | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/pyanaconda/installclasses/fedora.py b/pyanaconda/installclasses/fedora.py
> index e96d525..e7b5c57 100644
> --- a/pyanaconda/installclasses/fedora.py
> +++ b/pyanaconda/installclasses/fedora.py
> @@ -33,6 +33,7 @@ from pyanaconda import installmethod
> from pyanaconda import yuminstall
>
> import rpmUtils.arch
> +from decimal import Decimal
>
> class InstallClass(BaseInstallClass):
> # name has underscore used for mnemonics, strip if you dont need it
> @@ -113,10 +114,13 @@ class InstallClass(BaseInstallClass):
> return False
>
> def versionMatches(self, oldver):
> + if oldver is None:
> + return False
> +
> try:
> - oldVer = float(oldver)
> + oldVer = Decimal(oldver)
> # Trim off any "-Alpha" or "-Beta".
> - newVer = float(productVersion.split('-')[0])
> + newVer = Decimal(productVersion.split('-')[0])
> except ValueError:
> return True
That except should be changed to except Exception to catch the Decimal
exceptions.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Attachment:
pgp39xPfjm1ET.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
